FileInfoType: increase line length allowed #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old line length was 1024 characters. Increased this to 8192 -- May be need in HD if a large number of floating bodies are specified
deslaughter
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
The
FileInfoTypeused to store input files read into memory has a line length limit of 1024 characters. With the ability to add many input fields in some input file tables -- such as when HydroDyn when 14+ floating bodies are specified. Increasing this to 8192 characters to future proof a little. We may still hit limits with this again later, but perhaps we can migrate to a different input file format before then (wishful thinking I know).Related issue, if one exists
In trying to diagnose an issue brought up on the forum, we initially thought this might be the issue (apparently it isn't in that particular case). https://forums.nrel.gov/t/hydrodyn-nbody-maximum-limit/7418
Impacted areas of the software
All modules using the
FileInfoTypeparsing.Tests
No tests are affected.